Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix section day change form #440

Merged
merged 1 commit into from
Sep 14, 2023
Merged

Fix section day change form #440

merged 1 commit into from
Sep 14, 2023

Conversation

smartspot2
Copy link
Member

@smartspot2 smartspot2 commented Sep 10, 2023

See #439 for the original fix of the issue, but after merging in #429, there were additional errors due to the types used in the form (the state change failed to convert a string to an int type). This is a follow-up PR fixing that issue as well.

@smartspot2 smartspot2 added the bug Something isn't working label Sep 10, 2023
@smartspot2 smartspot2 self-assigned this Sep 10, 2023
@cypress
Copy link

cypress bot commented Sep 10, 2023

Passing run #203 ↗︎

0 78 0 0 Flakiness 0

Details:

Fix section day change form
Project: csm_web Commit: 62585ee5d6
Status: Passed Duration: 02:30 💡
Started: Sep 12, 2023 4:10 AM Ended: Sep 12, 2023 4:12 AM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

Copy link
Contributor

@ericyche ericyche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i see

Copy link
Contributor

@edwardneo edwardneo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and approved!

@smartspot2 smartspot2 merged commit 0af4cb6 into master Sep 14, 2023
16 checks passed
@smartspot2 smartspot2 deleted the fix/section-day-change branch September 14, 2023 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants